Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #12 #13

Merged
merged 1 commit into from Aug 17, 2022
Merged

Fix for #12 #13

merged 1 commit into from Aug 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 16, 2022

Additionally corrected spelling and formatting errors

Additionally corrected spelling and formatting errors
@michmich112
Copy link
Owner

michmich112 commented Aug 16, 2022

@luke-hagar-sp Awesome contribution! thank you so much!
Did you use ES-Lint for these formatting corrections?
If so would be good to add the ESlint config file for future updates to keep the same formatting

@ghost
Copy link
Author

ghost commented Aug 17, 2022

Hey @michmich112,

I just used the default VS Code Prettier plugin default configuration, I have my IDE set to format on Save.

Apologies if they are deviations from your standard.

@michmich112
Copy link
Owner

Hey @luke-hagar-sp
Can you follow the steps in this stack overflow answer to send the configs on your system.
I like them and want to make sure we add a prettier config file to make sure that future changes abide to that format.

link: https://stackoverflow.com/a/53419053/11521081

@michmich112 michmich112 added the enhancement New feature or request label Aug 17, 2022
@ghost
Copy link
Author

ghost commented Aug 17, 2022

@michmich112 There is no way to export the defaults as a file, but I went ahead and gathered them here.

{
arrowParens: "always",
bracketSameLine: false,
bracketSpacing: true,
embeddedLanguageFormatting: "auto",
endOfLine: "lf",
filepath: undefined,
htmlWhitespaceSensitivity: "css",
insertPragma: false,
jsxBracketSameLine: false,
jsxSingleQuote: false,
parser: undefined,
printWidth: 80,
proseWrap: "preserve",
quoteProps: "as-needed",
rangeEnd: Infinity,
requirePragma: false,
semi: true,
singleQuote: false,
tabWidth: 2,
trailingComma: "es5",
useTabs: false,
vueIndentScriptAndStyle: false
}

@michmich112 michmich112 changed the base branch from main to fix/#12 August 17, 2022 15:07
@michmich112
Copy link
Owner

Ok merging into fix/#12 and adding your prettier configuration.
This will be included in release 1.2.2
Thank You!

@michmich112 michmich112 merged commit 20bf87b into michmich112:fix/#12 Aug 17, 2022
@ghost
Copy link
Author

ghost commented Oct 11, 2022 via email

@michmich112
Copy link
Owner

@luke-hagar-sp No problem!
I didn't set a standard, so you've just created it :)
Thank you once again for your hard work and contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant