-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #12 #13
Fix for #12 #13
Conversation
@luke-hagar-sp Awesome contribution! thank you so much! |
Hey @michmich112, I just used the default VS Code Prettier plugin default configuration, I have my IDE set to format on Save. Apologies if they are deviations from your standard. |
Hey @luke-hagar-sp |
@michmich112 There is no way to export the defaults as a file, but I went ahead and gathered them here. {
arrowParens: "always",
bracketSameLine: false,
bracketSpacing: true,
embeddedLanguageFormatting: "auto",
endOfLine: "lf",
filepath: undefined,
htmlWhitespaceSensitivity: "css",
insertPragma: false,
jsxBracketSameLine: false,
jsxSingleQuote: false,
parser: undefined,
printWidth: 80,
proseWrap: "preserve",
quoteProps: "as-needed",
rangeEnd: Infinity,
requirePragma: false,
semi: true,
singleQuote: false,
tabWidth: 2,
trailingComma: "es5",
useTabs: false,
vueIndentScriptAndStyle: false
} |
Ok merging into fix/#12 and adding your prettier configuration. |
Hey Mich,
I just used the default VS Code Prettier plugin default configuration, I have my IDE set to format on Save.
Apologies if they are deviations from your standard.
Luke
From: Akumetsu ***@***.***>
Date: Tuesday, August 16, 2022 at 12:59 PM
To: michmich112/sveltekit-adapter-chrome-extension ***@***.***>
Cc: Luke Hagar ***@***.***>, Author ***@***.***>
Subject: Re: [michmich112/sveltekit-adapter-chrome-extension] Fix for #12 (PR #13)
Did you use ES-Lint for these formatting corrections? If so would be good to add the ESlint config file for future updates to keep the same formatting — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
This message came from outside your organization.
ZjQcmQRYFpfptBannerEnd
Did you use ES-Lint for these formatting corrections?
If so would be good to add the ESlint config file for future updates to keep the same formatting
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/michmich112/sveltekit-adapter-chrome-extension/pull/13*issuecomment-1216969274__;Iw!!MsNKLpFGsw!KDfcuxhGx1-wnAueeHAbvlOJ4Cnip_kzTfWQvLbqjqOSGHqjqmvSbw-ERWOwxzNJH0352G_rLOvt2xTki77CAemNhcE$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AXSFHH3UFPP3KTGXADC7GQTVZPJGHANCNFSM56WVIX6Q__;!!MsNKLpFGsw!KDfcuxhGx1-wnAueeHAbvlOJ4Cnip_kzTfWQvLbqjqOSGHqjqmvSbw-ERWOwxzNJH0352G_rLOvt2xTki77Cr7lCvaE$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@luke-hagar-sp No problem! |
Additionally corrected spelling and formatting errors