wrap @sveltejs/adapter-static #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps us more easily keep up with changes in the official svelte packages by using it directly and then doing our extra changes afterward. One downside to this is that `emptyOutDir` is no longer a valid option, and the directory is always emptied by the adapter-static adapt function. fixes michmich112#28
wallw-teal
changed the title
michmich112
approved these changes
Feb 26, 2023
|
I like this ! Due to the deprecation of the Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us more easily keep up with changes in the official svelte packages by using it directly and then doing our extra changes afterward.
One downside to this is that
emptyOutDiris no longer a valid option, and the directory is always emptied by the adapter-static adapt function.fixes #28
I also noticed that eslint/prettier/tests/tsc are not configured inside the reop, despite appearing in
package.json. So fingers crossed those all pass 馃. Additionally, I think I'm using a newer version ofnpmand it wanted to rewrite thepackage-lock.json. I can knock that out of the commit if that is annoying (that is causing the large diff).