Catchup to upstream repository #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed couple of packages no longer used.
This change moves data related to messages and bibliography into state, thus shifting some logic to reducers making callback memoisation more effective. This allows to skip re-rendering of bibliography items in response to some user actions improving overall performance.
Previously whenever style was changed, all <BibliographyItem>s would render twice.
Recent regression
If MultipleChoiceDialog was triggered from /import, it would fail to translate item selected in the dialog.
Should improve perceived snappiness of the app when quickly editing an item that is a part of larger bibliography.
Also tweaked code to work with zotero-translation-client > 4.0
* Remove use of zotero-api-client as all we need is a single static file (schema) so it makes little sense to bring in entire library for this one trivial request * Make api URL configurable * Adjust jest tests to use Node's fetch()
Also added a couple of APA-specific tests
This version is actually backported from FAQ on zbib.org, somehow updated version never made it into repository.
* Tweak confirm window to display imported citation in both current and incoming style (if one is set) * Add tests for various scenarios of importing a citation * Update web-common v0.3.0
* This resolves an issue where a translate called very early could fail because style xml is not yet fetched. This is unlikely to happen in practice but happens in tests. * Also added a test for processing multi-line pasted data
* Happened after picking "Copy HTML" option * Small visual regression caused by switching to dropdown from web-common probably in fd2c34f
Also removed comment from the default config which made it invalid JSON. (The same explanation is already included in README)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.