Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build plugins from @higi #155

Closed
mickael-kerjean opened this issue Apr 16, 2019 · 2 comments
Closed

Cannot build plugins from @higi #155

mickael-kerjean opened this issue Apr 16, 2019 · 2 comments

Comments

@mickael-kerjean
Copy link
Owner

mickael-kerjean commented Apr 16, 2019

From @higi:

Hey,
Linux 4.9.0-8-amd64 #1 SMP Debian 4.9.144-3.1 (2019-02-19) x86_64 GNU/Linux
used: mickael-kerjean/filestash@6501582

this gives me:
mkdir -p ./dist/data/plugin
go build -buildmode=plugin -o ./dist/data/plugin/image.so server/plugin/plg_image_light/index.go

server/plugin/plg_image_light/index.go:122:46: cannot use func literal (type func(io.ReadCloser, *common.App, *http.ResponseWriter, *http.Request) (io.Reader, error)) as type func(io.ReadCloser, *common.App, *http.ResponseWriter, *http.Request) (io.ReadCloser, error) in argument to common.Hooks.Register.ProcessFileContentBeforeSend

anynone can help pls?

mickael-kerjean/filestash-website#4

@mickael-kerjean
Copy link
Owner Author

I've change the API of the plugin several days ago and this is a refactoring error that got fix 2 days ago here.

I'll create a proper release in a few days but if you want to get something that works right now, I would advise to go on the IRC chanel on freenode: #filestash, there's a bot called blipblip that sent the link of the commit that pass the build (a log of this bot is available from http://irc.filestash.app), right now the latest stable one is 1623b53

@higi
Copy link

higi commented Apr 25, 2019

THX it is working:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants