Small fixes #5

janmeier · 2016-09-15T10:45:20Z

This fixes some small bugs I found during my benchmarks.

Belongs to many worked with string through, but not model. The check for paired was wrong (we checked on the prototype, not the instance). We were too quick to remove options.association, so it wasn't available the second time the loader runs
Handling on findById(null) - otherwise dataloader complains about trying to load a null key
We check before trying to shim again. This means we can call dataloaderSequelize(model) in the graphql-sequelize resolver and not worry about shimming more than once

janmeier · 2016-09-15T10:46:37Z

test/integration/belongsToMany.test.js

@@ -12,149 +12,162 @@ describe('belongsToMany', function () {
    this.sandbox.restore();
  });

-  describe('simple association', function () {


No code changes, just indentation and wrapping to test for both string and model through

mickhansen · 2016-09-15T11:32:39Z

1.2.1

janmeier added 3 commits September 15, 2016 09:18

fix: Bug for BTM through model, BTM.paired and BTM.association

ea2c96e

fix(findById): Handle null

325fa4f

fix(shimming): Don't shim multiple times

aefa3e9

janmeier assigned mickhansen Sep 15, 2016

janmeier commented Sep 15, 2016

View reviewed changes

mickhansen merged commit 09e1fe3 into master Sep 15, 2016

mickhansen deleted the smallFixes branch September 15, 2016 11:32

Provide feedback