Expose and prefix JSON type to avoid conflict with other libraries #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexGaspar
force-pushed
the
Fix-confict-JSON-type
branch
from
ad15d4e
to
1b66552
Compare
Current coverage is 92.66% (diff: 100%)@@ master #403 diff @@
==========================================
Files 11 11
Lines 368 368
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 341 341
Misses 27 27
Partials 0 0
|
mickhansen
reviewed
Jan 19, 2017
| @@ -5,5 +5,6 @@ module.exports = { | |||
| typeMapper: require('./typeMapper'), | |||
| attributeFields: require('./attributeFields'), | |||
| simplifyAST: require('./simplifyAST'), | |||
| relay: require('./relay') | |||
| relay: require('./relay'), | |||
| GraphQLJSON: require('./types/jsonType') | |||
There was a problem hiding this comment.
Sure! I've updated the pr :)
AlexGaspar
force-pushed
the
Fix-confict-JSON-type
branch
from
1b66552
to
68db423
Compare
|
Is there something preventing this from being merged? |
|
@AlexGaspar Nope, not at all, i forgot to merge & release, will do it tomorrow. |
|
v5.0.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #343 ideas