Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added responsive design & fixed typo in landing page #3

Merged
merged 3 commits into from
Jan 29, 2017
Merged

Added responsive design & fixed typo in landing page #3

merged 3 commits into from
Jan 29, 2017

Conversation

bastilimbach
Copy link
Contributor

@bastilimbach bastilimbach commented Jan 29, 2017

Important: Do not merge into master!
I added the necessary css to achieve a responsive design and fixed some typos.
I also deleted some unnecessary files.

If you create a "gh-pages" branch and we merge my changes into "gh-pages", GitHub automatically recognizes this as your project landing page. More infos here.
After the creation of the "gh-pages" branch I will change the base branch of this PR so that you just need to click on the green merge button 馃槈

Also the URL is a bit cleaner with a "gh-pages" branch:

Live Demo

@micku7zu micku7zu changed the base branch from master to gh-pages January 29, 2017 17:16
@micku7zu micku7zu merged commit ebab388 into micku7zu:gh-pages Jan 29, 2017
@micku7zu
Copy link
Owner

Thanks, merged, fixed some small things and it seems that everything it's working great with "gh-pages".

If you have some way to include the credits in the mobile version it would be great 馃槃 .
It's important for me to put tilt.js logo too

@bastilimbach
Copy link
Contributor Author

I thought about including the tilt.js logo beneath the vanilla logo, but I think it would be a little confusing for some people to have two boxes of the same style on top of the page. What do you think? Would it be ok to put the logo and credit of tilt.js at the bottom of the page? (On mobile only)

@micku7zu
Copy link
Owner

Yes, I think that a footer with the credits, which is visible only on mobile, it would be great.

@bastilimbach
Copy link
Contributor Author

I'm on it 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants