69 legend and colour improvements #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good :) |
micmro
commented
Dec 6, 2016
| @@ -9,8 +9,7 @@ export function makeLegend(): HTMLUListElement { | |||
| <li class="legend-blocked" title="Time spent in a queue waiting for a network connection.">Blocked</li> | |||
| <li class="legend-dns" title="DNS resolution time.">DNS</li> | |||
| <li class="legend-connect" title="Time required to create TCP connection.">Connect</li> | |||
| <li class="legend-ssl" title="Time required for SSL/TLS negotiation. | |||
| Time is also included in the connect field (to ensure backward compatibility with HAR 1.1).">SSL (TLS)</li> | |||
| <li class="legend-ssl" title="Time required for SSL/TLS negotiation.">SSL (TLS)</li> | |||
There was a problem hiding this comment.
connect and TLS are seperated in the code already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.