Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) #1712

Open
wants to merge 17 commits into
base: iron
Choose a base branch
from

Conversation

gbr1
Copy link

@gbr1 gbr1 commented Mar 21, 2024

By importing time.h instead of sys/time.h you can build micro-ros for Arduino UNO R4.

It addresses issue: #1461

This PR was tested on following targets:

  • mbed (Arduino GIGA R1)
  • m4 (Arduino UNO R4 Minima)
  • stm32 (STMicroelectronics Nucleo F401RE)

@gbr1
Copy link
Author

gbr1 commented Mar 27, 2024

I added also Arduino Giga (USB and WiFi).

It is practically the same of an Arduino Portenta H7, so it was quite easy

@gbr1 gbr1 changed the title fixed time.h import fixed time.h import, added Arduino Giga R1 (USB and WiFi) Mar 27, 2024
@gbr1
Copy link
Author

gbr1 commented Mar 27, 2024

Latest PR adds WiFi for Arduino UNO R4.

@gbr1 gbr1 changed the title fixed time.h import, added Arduino Giga R1 (USB and WiFi) fixed time.h import, added Arduino UNO R4 minima (USB), Arduino UNO R4 WiFi (USB and WiFi), Arduino Giga R1 (USB and WiFi) Mar 27, 2024
@gbr1
Copy link
Author

gbr1 commented Jul 10, 2024

Hi @pablogs9 , any update on this PR?

@pablogs9
Copy link
Member

Could you please add the new supported boards to supported boards community table, also is there a possibility of having some CI on this new boards?

@pablogs9
Copy link
Member

CI failing

Comment on lines +72 to +75
arduino-cli compile --fqbn arduino:mbed_nano:nanorp2040connect /github/home/Arduino/libraries/micro_ros_arduino/examples/micro-ros_publisher -v
arduino-cli compile --fqbn arduino:mbed_nano:nanorp2040connect /github/home/Arduino/libraries/micro_ros_arduino/examples/micro-ros_decibels -v
arduino-cli compile --fqbn arduino:mbed_nano:nanorp2040connect /github/home/Arduino/libraries/micro_ros_arduino/examples/micro-ros_IMU_ML -v
arduino-cli compile --fqbn arduino:mbed_nano:nanorp2040connect /github/home/Arduino/libraries/micro_ros_arduino/examples/micro-ros_publisher_wifi -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arduino splitted mbed core which now is deprecated

Comment on lines +84 to +85
arduino-cli compile --fqbn arduino:mbed_portenta:envie_m7 /github/home/Arduino/libraries/micro_ros_arduino/examples/micro-ros_publisher -v
arduino-cli compile --fqbn arduino:mbed_portenta:envie_m7 /github/home/Arduino/libraries/micro_ros_arduino/examples/micro-ros_publisher_wifi -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

portenta is now under mbed_portenta

# Build micro-ros_publisher-wifi_at for WiFi non-native board with ESP-AT
arduino-cli compile --fqbn arduino:mbed:pico /github/home/Arduino/libraries/micro_ros_arduino/examples/micro-ros_publisher_wifi_at -v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this line because pico is now under mbed_rp2040

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not clear to me why you build pico + wifi

@gbr1
Copy link
Author

gbr1 commented Jul 11, 2024

@pablogs9 it should work now, let me know

@gbr1
Copy link
Author

gbr1 commented Jul 11, 2024

I don't understand how it works, I have modified only iron branch, should I change manually also rolling and humble?
Screenshot 2024-07-11 at 16 28 38

@pablogs9
Copy link
Member

I don't understand how it works,

How what works?

@gbr1
Copy link
Author

gbr1 commented Jul 11, 2024

I don't understand how it works,

How what works?

The CI

@pablogs9
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants