Skip to content

Commit

Permalink
Clarifications in documentation
Browse files Browse the repository at this point in the history
Signed-off-by: Arne Nordmann <arne.nordmann@de.bosch.com>
  • Loading branch information
norro committed Aug 7, 2020
1 parent ffe02c6 commit 95caac6
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions system_modes/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ $ `ros2 launch system_modes mode_monitor.launch.py modelfile:=[path/to/modelfile

### Error Handling and Rules

If the _actual_ state/mode of the system or any of its parts diverges from the _target_ state/mode, we define rules that try to bring the system back to its _target_ state/mode. Rules work in a bottom-up manner, i.e. starting from correcting nodes before sub-systems before systems. Rules are basically defined in the following way:
If the _actual_ state/mode of the system or any of its parts diverges from the _target_ state/mode, we define rules that try to bring the system back to a valid _target_ state/mode, e.g., a degraded mode. Rules work in a bottom-up manner, i.e. starting from correcting nodes before sub-systems before systems. Rules are basically defined in the following way:

```pseudo
if:
Expand All @@ -133,7 +133,7 @@ then:
```

if _actual_ state/mode and _target_ state/mode diverge, but there is no rule for this exact situation, the bottom-up rules will just try to return the system/part to its _target_ state/mode.
TODO: dangerous: what's happening, if the system is already on its way. E.g., a system or part was just commanded to transition to _ACTIVE.foo_, but is currently _activating_ (so doing everything right). In this case we have to avoid that the bottom-up rules will trigger.
*Potentiall dangereous, to be discussed:* what's happening, if the system is already on its way. E.g., a system or part was just commanded to transition to _ACTIVE.foo_, but is currently _activating_ (so doing everything right). In this case we have to avoid that the bottom-up rules will trigger.

## How to Apply

Expand Down

0 comments on commit 95caac6

Please sign in to comment.