Mode manager prevents redundant mode changes #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before executing a requested mode change, i.e. applying the according changes, it is now checking whether the mode is already active. If so, no action is taken, but mode change service request is still returned with success. #60 Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 27.67% 27.63% -0.04%
==========================================
Files 12 12
Lines 990 995 +5
Branches 710 714 +4
==========================================
+ Hits 274 275 +1
+ Misses 259 258 -1
- Partials 457 462 +5
Continue to review full report at Codecov.
|
Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
nielsvd
requested changes
Apr 6, 2021
nielsvd
approved these changes
Apr 6, 2021
|
Thanks for the review, Niels! |
norro
added a commit
that referenced
this pull request
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before executing a requested mode change, i.e. applying the according changes, it is now checking whether the mode is already active. If so, no action is taken, but mode change service request is still returned with success.
#60