Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improvements of launch tests #72

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Conversation

norro
Copy link
Collaborator

@norro norro commented Apr 8, 2021

Now using launch_ros node action

Signed-off-by: Nordmann Arne (CR/ADT3) arne.nordmann@de.bosch.com

* Now using launch_ros node action

Signed-off-by: Nordmann Arne (CR/ADT3) <arne.nordmann@de.bosch.com>
@norro norro self-assigned this Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #72 (98d067d) into master (0b90a5d) will increase coverage by 3.91%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   27.57%   31.48%   +3.91%     
==========================================
  Files          14       14              
  Lines        1048     1048              
  Branches      754      754              
==========================================
+ Hits          289      330      +41     
+ Misses        272      159     -113     
- Partials      487      559      +72     
Impacted Files Coverage Δ
system_modes/src/system_modes/mode_observer.cpp 20.00% <0.00%> (ø)
system_modes/src/system_modes/mode_inference.cpp 35.42% <0.00%> (+0.27%) ⬆️
system_modes/src/system_modes/mode.cpp 55.73% <0.00%> (+9.83%) ⬆️
system_modes/src/system_modes/mode_monitor.cpp 26.98% <0.00%> (+26.19%) ⬆️
system_modes/include/system_modes/mode_monitor.hpp 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b90a5d...98d067d. Read the comment docs.

@norro norro requested a review from ralph-lange April 8, 2021 07:53
Copy link
Contributor

@ralph-lange ralph-lange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@norro norro merged commit 2917384 into master Apr 9, 2021
@norro norro deleted the fix/launch-test-nodes branch April 9, 2021 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants