feat: Add support for meta through post requests

Fixes #24
micro-analytics · Jun 18, 2017 · 50186f4 · 50186f4
1 parent 22251ca
commit 50186f4
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 13 deletions.
diff --git a/packages/micro-analytics-cli/src/handler.js b/packages/micro-analytics-cli/src/handler.js
@@ -1,5 +1,5 @@
 const url = require('url');
-const { send, createError, sendError } = require('micro');
+const { json, send, createError, sendError } = require('micro');
 
 const db = require('./db');
 const healthcheckHandler = require('./healthcheck');
@@ -24,6 +24,14 @@ function realtimeHandler(req, res) {
   }
 }
 
+async function readMeta(req) {
+  try {
+    return (await json(req)).meta;
+  } catch (error) {
+    return null;
+  }
+}
+
 async function analyticsHandler(req, res) {
   const { pathname, query } = url.parse(req.url, /* parseQueryString */ true);
   res.setHeader('Access-Control-Allow-Origin', '*');
@@ -55,17 +63,18 @@ async function analyticsHandler(req, res) {
   const shouldIncrement = String(query.inc) !== 'false';
   try {
     const currentViews = (await db.has(pathname)) ? (await db.get(pathname)).views.length : 0;
-    // Add a view and send the total views back to the client
-    if (shouldIncrement) {
-      await pushView(pathname, { time: Date.now() });
+    const meta = await readMeta(req);
+
+    const data = { time: Date.now() };
+    if (meta) {
+      data.meta = meta;
     }
-    if (req.method === 'GET') {
-      send(res, 200, {
-        views: shouldIncrement ? currentViews + 1 : currentViews,
-      });
-    } else {
-      send(res, 200);
+
+    if (shouldIncrement) {
+      await pushView(pathname, data);
     }
+
+    send(res, 200, { views: shouldIncrement ? currentViews + 1 : currentViews });
   } catch (err) {
     console.log(err);
     throw createError(500, 'Internal server error.');

diff --git a/packages/micro-analytics-cli/tests/items.test.js b/packages/micro-analytics-cli/tests/items.test.js
@@ -41,9 +41,20 @@ describe('single', () => {
     expect(body.views).toEqual(1);
   });
 
-  it('should not return anything for a POST request', async () => {
-    const body = await request.post(`${server.url}/existant`);
-    expect(body).toEqual('');
+  describe('POST', () => {
+    it('should increment the views of an existant path', async () => {
+      await request.post(`${server.url}/existant`);
+      const body = JSON.parse(await request(`${server.url}/existant`));
+      expect(body.views).toEqual(2);
+    });
+
+    it('should increment the views of an existant path and store metadata', async () => {
+      await request.post(`${server.url}/existant`, {
+        body: JSON.stringify({ meta: { browser: 'IE 6' } }),
+      });
+      const [data] = (await db.get('/existant')).views;
+      expect(data).toMatchObject({ meta: { browser: 'IE 6' } });
+    });
   });
 });