Streamer Software #460
Merged
Streamer Software #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linknum23
requested changes
Apr 24, 2023
… on web interface if no zones exist.
Lohrer
requested changes
Apr 26, 2023
There was a problem hiding this comment.
First off, rebase on develop.
Things to fix that I've noticed so far:
- RCA inputs shouldn't be available.
- Factory reset config adds zones.
- Updates fail due to not being able to program the preamp firmware.
Minor issue that can be ignored or fixed later:
- Zones still show up in the API documentation page.
The example preset "Mute Some" returns "TypeError: response.presets is undefined" - Mute all still occasionaly gets added (not sure by what) as a preset (which fails to run properly).
- The RCA audiodetector will be installed (note, there's currently a bug where a deploy won't install the audiodetector but the updater will)
- Shortcuts to tests that won't work are still placed on the Desktop.
-
Error: no preamps found. AmpliPi still tries to connect to the non-existent preamp. I think enough checks are in place that no attempted I2C messages are sent but we should probably be using the "Mock" preamp. - "RCA Input" is a Stream Type option for creating a new Stream. Trying to create one currently fails however.
Open questions:
- Keep amplipi hostname?
- I get bluetooth errors at startup even though no bluetooth streams are configured. It's possible this is fixed by rebasing on develop which has bluetooth updates.
/usr/bin/bluetoothctl
Error checking for bluetooth hardware: Command '['bluetoothctl', 'show']' timed out after 0.5 seconds
bluetooth dongle unavailable
linknum23
force-pushed
the
streamer-software
branch
from
69c056e
to
d48542d
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## develop #460 +/- ##
===========================================
- Coverage 56.25% 52.67% -3.58%
===========================================
Files 12 22 +10
Lines 2839 5272 +2433
===========================================
+ Hits 1597 2777 +1180
- Misses 1242 2495 +1253
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Updates should be successful now even when a preamp board doesn't exist. NOTE: This has a documented dependency that the software must be run once before firmware is installed.
Display was getting into a bad state and the old reset was leaving the display in a busy state. Manually resetting the display using the reset pin got the display out of a bad state. This may fix similar problems in the future but is unproven.
Satisfying pylint
For now these are specified in requirements.txt
This appears to be indicated by a timeout when calling the bluetooth show command
linknum23
requested review from
linknum23,
jonahshader and
Lohrer
and removed request for
linknum23
|
@klay2000 Can you look at the changes I made to the display and verify that they make sense? |
jonahshader
reviewed
May 3, 2023
linknum23
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for supporting streamer box, eeprom(s), and eink display.