Remove time-consuming copy on first boot #519
Conversation
| # This structure is left in place for future partitions... but it basically does nothing now. | ||
| for PART in ${ROOT_DEV}p2; do |
There was a problem hiding this comment.
Maybe just remove this? The loop over 2 things that are then handled completely differently was kinda silly in the first place...
There was a problem hiding this comment.
i'm inclined to leave it in place only cuz the note about e2fsck returning >0 exit code on successful runs was unexpected and took some debugging, but i can if you care. agreed it was silly to handle the cases differently 🥴
There was a problem hiding this comment.
Ah I misread the != as =, this makes more sense now. Plus since you've already tested it as written I'm fine with it staying this way.
|
This has now been tested too. |
| # This structure is left in place for future partitions... but it basically does nothing now. | ||
| for PART in ${ROOT_DEV}p2; do |
There was a problem hiding this comment.
Ah I misread the != as =, this makes more sense now. Plus since you've already tested it as written I'm fine with it staying this way.
|
The display code appears to fail the tests, I assume that's not due to this PR? If not, we should still fix those quickly so we don't keep ignoring test outputs. |
This PR removes the time-consuming copying process on first boot. It leaves in place the partition creation process. This will allow us to punt on #516 as a blocker for 0.3.0 stable release.
I have not tested this yet & will not merge til I have done so, but there's nothing stopping feedback at the moment.