Fix Disconnected Zone Bug

[klay2000]

This likely fixes #527

[codecov-commenter]

Codecov Report

Attention: 1451 lines in your changes are missing coverage. Please review.

Comparison is base (17390bb) 56.25% compared to head (0ace166) 51.52%.
Report is 633 commits behind head on develop.

Files	Patch %	Lines
amplipi/display/tftdisplay.py	0.00%	407 Missing ⚠️
amplipi/streams.py	45.86%	275 Missing ⚠️
amplipi/display/epd2in13_V3.py	0.00%	230 Missing ⚠️
amplipi/display/einkdisplay.py	0.00%	124 Missing ⚠️
amplipi/eeprom.py	38.92%	91 Missing ⚠️
amplipi/ctrl.py	67.98%	81 Missing ⚠️
amplipi/mpris.py	37.62%	63 Missing ⚠️
amplipi/display/common.py	0.00%	53 Missing ⚠️
amplipi/display/display.py	0.00%	36 Missing ⚠️
amplipi/updater/asgi.py	0.00%	36 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #528      +/-   ##
===========================================
- Coverage    56.25%   51.52%   -4.73%     
===========================================
  Files           12       23      +11     
  Lines         2839     5624    +2785     
===========================================
+ Hits          1597     2898    +1301     
- Misses        1242     2726    +1484     

Flag	Coverage Δ
unittests	51.52% <36.05%> (-4.73%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[linknum23]

Looking at this again. I think we need to fix the preamp code to handle a zone source of -1. Also that max() should be applied to all zone's sources I think.

[linknum23]

Here's what we need to do to fix this. Sorry if this is needlessly prescriptive

• Add a test that sets zone sources to -1 and back
• Add an assert in rt.py Mock update_zone_sources that checks if any of the sources are outside range(4)
• Verify the test fails
• Fix the code in set_zones to configure the source_ids sent to the rt within range(4) suggestion use source_id=0

[linknum23]

What is this file?

[linknum23]

Suggested change

	zone_sources = [utils.clamp(zone.source_id, 3, 0) for zone in zones]
	zone_sources = [utils.clamp(zone.source_id, 0, 3) for zone in zones]

[linknum23]

That doesn't change functionality, but matches the clamp signature

[linknum23]

Looks good, you may want to squash your commits after removing that weird file