Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Webapp Off Amplipi #533

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Build Webapp Off Amplipi #533

merged 1 commit into from
Nov 20, 2023

Conversation

klay2000
Copy link
Contributor

Changed where webapp is built and added building the webapp to the release docs.

@codecov-commenter
Copy link

Codecov Report

Attention: 1452 lines in your changes are missing coverage. Please review.

Comparison is base (17390bb) 56.25% compared to head (ba00f0f) 51.51%.
Report is 633 commits behind head on develop.

Files Patch % Lines
amplipi/display/tftdisplay.py 0.00% 407 Missing ⚠️
amplipi/streams.py 45.86% 275 Missing ⚠️
amplipi/display/epd2in13_V3.py 0.00% 230 Missing ⚠️
amplipi/display/einkdisplay.py 0.00% 124 Missing ⚠️
amplipi/eeprom.py 38.92% 91 Missing ⚠️
amplipi/ctrl.py 67.58% 82 Missing ⚠️
amplipi/mpris.py 37.62% 63 Missing ⚠️
amplipi/display/common.py 0.00% 53 Missing ⚠️
amplipi/display/display.py 0.00% 36 Missing ⚠️
amplipi/updater/asgi.py 0.00% 36 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #533      +/-   ##
===========================================
- Coverage    56.25%   51.51%   -4.75%     
===========================================
  Files           12       23      +11     
  Lines         2839     5622    +2783     
===========================================
+ Hits          1597     2896    +1299     
- Misses        1242     2726    +1484     
Flag Coverage Δ
unittests 51.51% <35.97%> (-4.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rtertiaer rtertiaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@klay2000 klay2000 merged commit 2eb8ce9 into develop Nov 20, 2023
2 checks passed
@klay2000 klay2000 deleted the build-webapp branch November 20, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants