-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Logitech Media Server in mainsteam AmpliPi #549
Conversation
b2d294e
to
2ee7fd2
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #549 +/- ##
===========================================
- Coverage 51.52% 51.52% -0.01%
===========================================
Files 23 24 +1
Lines 5624 5673 +49
===========================================
+ Hits 2898 2923 +25
- Misses 2726 2750 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
per in-person review:
|
amplipi/ctrl.py
Outdated
if self.lms_mode and stream.type == 'lms': | ||
self.streams[stream.id].activate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered doing this in the constructor but the controller is the bit that knows & cares about if it's in LMS mode.
Testing this on
|
@linknum23 I was not able to replicate your problem above. I'd love to hash this out a smidge in person, because there's some wackiness with our multiple test beds that I think is complicating things a little bit. |
@linknum23 I think the thing you bumped into is fixed now. The bug was that every other restart of I'm going to continue testing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR really needs #557 for zones to work right but as is it is pretty fantastic. Nice work @rtertiaer
…ge squeezelite with configure.py
0d470f2
to
6799b8e
Compare
Filing this as a draft for now. When completed, this ought to close #532 . I'd like some early feedback because we'd like to ship 0.3.0 before the holidays.