Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert Pandora process_monitor.py changes from 09ca4fa, 461cd58 #688

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

rtertiaer
Copy link
Contributor

What does this change intend to accomplish?

This PR reverts the changes from 09ca4fa, 461cd58. We suspect these have caused stability concerns (#636, #663, and here.)

These changes have had seemingly limited utility, and Pandora worked well before. We stand to lose close to nothing reverting these changes.

I'm currently running this branch on an AmpliPi overnight and intend to ship it tomorrow if it works swell.

Checklist

  • Have you tested your changes and ensured they work? (see above)
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • If applicable, have you updated the documentation/manual?
  • If applicable, have you updated the CHANGELOG?
  • Does your submission pass linting & tests? You can test on localhost using ./scripts/test
  • Have you written new tests for your core features/changes, as applicable?

Copy link
Contributor

@linknum23 linknum23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense as a short term fix. We really need to characterize the failure/stop conditions of Pandora to rubustify this in the future.

@rtertiaer rtertiaer merged commit 9af54b4 into main Apr 19, 2024
3 checks passed
@rtertiaer rtertiaer deleted the pianobar_no_procmon branch April 19, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants