-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Power Board Rev 6 #724
Conversation
5fd4095
to
1c6bbdb
Compare
3c56b86
to
ab5c183
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 50.90% 49.52% -1.38%
==========================================
Files 25 26 +1
Lines 5838 6366 +528
==========================================
+ Hits 2972 3153 +181
- Misses 2866 3213 +347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Gonna have to make some changes here, PG_9V is inconsistent depending on the hardware setup. The hardware revision with Power Board 3.B is reporting a bad PG_9V, which makes sense since that signal doesn't exist and the current firmware implementation assumes all older hardware has that signal. |
dd36fca
to
7d1ffc6
Compare
This appears to work on amplipi256 (preamp v4, power v6), amplipi197 (preamp v3, power v4), and lamplipi (preamp v3, power v3). I still need to test on the original units (preamp v2 and power v2) and the intermediate combo of preamp v4 and power v4. |
What does this change intend to accomplish?
Complete #723
Checklist