-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support tunnel MVP #731
support tunnel MVP #731
Conversation
I assume I can just test this on my amplipi? |
Trying this out we found a couple of issues
|
8a2e73b
to
6dabb81
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
- Coverage 50.90% 49.49% -1.42%
==========================================
Files 25 26 +1
Lines 5838 6352 +514
==========================================
+ Hits 2972 3144 +172
- Misses 2866 3208 +342
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
As discussed in-person:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Nice work Ryan!
7925723
to
2a7a196
Compare
This latest rendition is running on a customer's appliance in the field and works a charm. I'm gonna let it run for a day or two but I feel pretty comfortable with this rendition making it into a release. |
pyproject.toml
Outdated
@@ -1,6 +1,6 @@ | |||
[tool.poetry] | |||
name = "amplipi" | |||
version = "0.3.5" | |||
version = "0.3.5+7d6801f-support_tunnel-dirty" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
2e36003
to
213acab
Compare
213acab
to
8ebbb99
Compare
What does this change intend to accomplish?
This PR brings in our support tunnel software in a pretty MVP fashion. It has an interface in the updater to permit requesting a support tunnel. It also implements two commands that are run via cronjob - one that reaps/garbage collects completed or expired tunnel sessions, and one that checks if any requested tunnels have launched in the remote side.
I'm submitting now for review, though I still need to check a couple of the checklist items off the list. I'd also like to produce a write-up describing this stack before landing it in a release, but I'd like to do that soon too.
Checklist
./scripts/test