Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review workflow #1072

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 37 additions & 0 deletions .github/workflows/code-review.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# This workflow will do a clean installation of node dependencies, cache/restore them, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Code Review CI

on:
push:
branches: [ dev ]
pull_request:
branches: [ dev ]

jobs:
code-review:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x]
# See supported Node.js release schedule at https://nodejs.org/en/about/releases/

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: yarn run bootstrap
- run: yarn run build
- run: yarn run lint
- run: yarn run test
- name: Run yarn run commitlint
run: |
printf "%s\n\n" "$(git log --pretty=format:'%ad %h by %an, %s' -n $((${{ github.event.pull_request.commits }} + 1)))"
yarn run commitlint --from HEAD~${{ github.event.pull_request.commits }} --to HEAD
2,474 changes: 1,237 additions & 1,237 deletions dev/children/angular11/yarn.lock

Large diffs are not rendered by default.

2,956 changes: 1,478 additions & 1,478 deletions dev/children/react17/yarn.lock

Large diffs are not rendered by default.

2,294 changes: 1,147 additions & 1,147 deletions dev/children/vue2/yarn.lock

Large diffs are not rendered by default.

3,678 changes: 1,839 additions & 1,839 deletions dev/main-react16/yarn.lock

Large diffs are not rendered by default.

1,308 changes: 675 additions & 633 deletions dev/main-vite/yarn.lock

Large diffs are not rendered by default.

2,298 changes: 1,149 additions & 1,149 deletions dev/main-vue2/yarn.lock

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions src/__tests__/unit/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@ describe('utils', () => {
expect(Utils.formatAppURL(null)).toBe('')
expect(Utils.formatAppURL('')).toBe('')
expect(Utils.formatAppURL('htt://abc')).toBe('')
expect(Utils.formatAppURL('abc')).toBe('')
expect(jestConsoleError).toBeCalledWith('[micro-app]', expect.anything())
expect(Utils.formatAppURL('abc')).toBe('http://localhost/abc/')
})

test('utils ==> getEffectivePath', () => {
Expand Down