Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace service prefix with FQDN style prefix #1107

Merged
merged 2 commits into from Jan 12, 2020

Conversation

ucosty
Copy link
Contributor

@ucosty ucosty commented Jan 12, 2020

According to the k8s documentation, the label and annotation prefixes should be in the format of a FQDN, with dot separated labels of no more than 63 characters. The current label and annotation paramteres are rejected by the k8s api, most likely because they have two forward slashes in them.

According to the k8s documentation, the label and annotation prefixes should be in the format of a FQDN, with dot separated labels of no more than 63 characters. The current label and annotation paramteres are rejected by the k8s api, most likely because they have two forward slashes in them.
@crashdump
Copy link

Just to add the @ucosty, the error we are seeing is the following:

Server register error: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"Pod \"micro-api-7fcc79495-9rlwt\" is invalid: [metadata.labels: Invalid value: \"micro/service/go.micro.api\": a qualified name must consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyName', or 'my.name', or '123-abc', regex used for validation is '([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9]') with an optional DNS subdomain prefix and '/' (e.g. 'example.com/MyName').

Using the path above solves the issue.

@asim
Copy link
Member

asim commented Jan 12, 2020

Can you please change the prefix to go.micro?

@ucosty
Copy link
Contributor Author

ucosty commented Jan 12, 2020

@asim done

@asim asim merged commit 75b1a62 into go-micro:master Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants