feat(config): add withFS option to file source #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asynxc
force-pushed
the
feat/config/source/file/add_withfs
branch
2 times, most recently
from
0c4a876
to
45fb546
Compare
asynxc
force-pushed
the
feat/config/source/file/add_withfs
branch
from
45fb546
to
c847dc8
Compare
Davincible
approved these changes
Sep 24, 2022
|
Thanks for the PR! Just curious, what is your use case for this? |
|
@Davincible Thanks ^^ working on a project that have a lot of configurations and we want it to have sane defaults. this require us to have a default configurations that gets merged/overridden by other (user) provided files... with this PR, now we can embed a default config via embed.FS and use it as a source file, without the hustle of handling that in the project codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce a new option to the file module that allow a user either to pass in a file path or FS handler. as argument. (if both options provided, FS handler is used)
This options allow the use of a raw or embed.FS as data source. (e.g: as default config data, overridden by subsequent provided sources).
Any feedback is very welcome ^^