fix(config): fix file source watcher stop behavior when Stop is called #2630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asynxc
force-pushed
the
fix/config/source/file/watcher_stop
branch
2 times, most recently
from
16297c6
to
7f9e95b
Compare
asynxc
force-pushed
the
fix/config/source/file/watcher_stop
branch
from
947526f
to
d7eb0d6
Compare
Davincible
approved these changes
Apr 26, 2023
|
Hey! looks good, added tests are nice. Thanks for the work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix a minor bug in config source file watcher as described in the Issue #2629
closes #2629
any feedback is very welcome