Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log to sentry and continue if JHU vaccine data is unavailable #1655

Closed
wants to merge 1 commit into from
Closed

Log to sentry and continue if JHU vaccine data is unavailable #1655

wants to merge 1 commit into from

Conversation

shawnbiesan2
Copy link
Collaborator

This PR allows the prevalance script to continue running in the case of missing JHU Vaccination Data by logging to Sentry instead of throwing an exception

@netlify
Copy link

netlify bot commented Nov 27, 2022

Deploy Preview for microcov ready!

Name Link
🔨 Latest commit 4ada923
🔍 Latest deploy log https://app.netlify.com/sites/microcov/deploys/6383a2b5ccf1f5000849736b
😎 Deploy Preview https://deploy-preview-1655--microcov.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shawnbiesan2
Copy link
Collaborator Author

This is the very literal "keep prevalance running" fix. Not sure if there should be more thought put into how the overall model is impacted when JHU Vaccine data is unavailable.

@coachnate
Copy link
Collaborator

I just dropped a comment on the issue related to this. I was thinking about adding some try/catch blocks in there. Thoughts?

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #1655 (4ada923) into main (d656f8b) will increase coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
+ Coverage   43.13%   43.21%   +0.08%     
==========================================
  Files         103      103              
  Lines        2300     2300              
  Branches      525      525              
==========================================
+ Hits          992      994       +2     
  Misses       1206     1206              
+ Partials      102      100       -2     
Impacted Files Coverage Δ
update_prevalence.py 30.16% <0.00%> (ø)
src/pages/Calculator.tsx 79.80% <0.00%> (+1.92%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shawnbiesan2
Copy link
Collaborator Author

Closing as #1654 was resolved by upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants