Save model predictions for a variety of scenarios for later analysis. #1772
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1772 +/- ##
==========================================
+ Coverage 66.14% 66.18% +0.03%
==========================================
Files 104 104
Lines 2892 2892
Branches 541 541
==========================================
+ Hits 1913 1914 +1
+ Misses 825 824 -1
Partials 154 154
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zack112358
force-pushed
the
validation-scenarios
branch
2 times, most recently
from
73f2e21
to
621e1ac
Compare
Good question. Based on the upper right updates section, it looks like some updates for Omicron went in Jan 4, 2022, so looking around that time range might be one idea. There was also a PR merged and then reverted recently - see #1421 and #1693.
Makes sense to me! |
There was a problem hiding this comment.
This is great progress towards a powerful goal--thanks so much for digging in on it! Thoughts:
-
If this is enough for any kind of rough and ready use, a comment or two or a line in README.md would be appreciated on how to use it or at least what it is and what it does. If it's just incremental progress to share or checkpoint, no worries!
-
Let me know if you could use a hand on the Typescript errors.
-
Are the yarn.lock changes necessary? I didn't see any corresponding package.json changes. I wonder iif they might be breaking the netlify build:
https://app.netlify.com/sites/microcov/deploys/63cb654170771300088b86ef
11:09:48 PM: yarn run v1.22.4
11:09:48 PM: $ REACT_APP_DEPLOY_PRIME_URL="$DEPLOY_PRIME_URL" react-scripts build
11:09:49 PM: Creating an optimized production build...
11:09:50 PM: Failed to compile.
11:09:50 PM:
11:09:50 PM: ./src/index.tsx
11:09:50 PM: Error: [BABEL] /opt/build/repo/src/index.tsx: Cannot find module '@babel/helper-builder-react-jsx'
11:09:50 PM: Require stack:
11:09:50 PM: - /opt/build/repo/node_modules/babel-preset-react-app/node_modules/@babel/preset-react/node_modules/@babel/plugin-transform-react-jsx/lib/transform-classic.js
11:09:50 PM: - /opt/build/repo/node_modules/babel-preset-react-app/node_modules/@babel/preset-react/node_modules/@babel/plugin-transform-react-jsx/lib/index.js
11:09:50 PM: - /opt/build/repo/node_modules/babel-preset-react-app/node_modules/@babel/preset-react/lib/index.js
11:09:50 PM: - /opt/build/repo/node_modules/babel-preset-react-app/create.js
11:09:50 PM: - /opt/build/repo/node_modules/babel-preset-react-app/index.js
11:09:50 PM: - /opt/build/repo/node_modules/react-scripts/node_modules/@babel/core/lib/config/files/plugins.js
11:09:50 PM: - /opt/build/repo/node_modules/react-scripts/node_modules/@babel/core/lib/config/files/index.js
11:09:50 PM: - /opt/build/repo/node_modules/react-scripts/node_modules/@babel/core/lib/index.js
11:09:50 PM: - /opt/build/repo/node_modules/react-scripts/node_modules/babel-loader/lib/index.js
11:09:50 PM: - /opt/build/repo/node_modules/loader-runner/lib/loadLoader.js
11:09:50 PM: - /opt/build/repo/node_modules/loader-runner/lib/LoaderRunner.js
11:09:50 PM: - /opt/build/repo/node_modules/webpack/lib/NormalModule.js
11:09:50 PM: - /opt/build/repo/node_modules/webpack/lib/NormalModuleFactory.js
11:09:50 PM: - /opt/build/repo/node_modules/webpack/lib/Compiler.js
11:09:50 PM: - /opt/build/repo/node_modules/webpack/lib/webpack.js
11:09:50 PM: - /opt/build/repo/node_modules/react-scripts/scripts/build.js (While processing: "/opt/build/repo/node_modules/babel-preset-react-app/index.js")
11:09:50 PM: error Command failed with exit code 1. (https://ntl.fyi/exit-code-1)
11:09:50 PM: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
11:09:50 PM:
11:09:50 PM: "build.command" failed
11:09:50 PM: ────────────────────────────────────────────────────────────────
11:09:50 PM:
11:09:50 PM: Error message
11:09:50 PM: Command failed with exit code 1: yarn build (https://ntl.fyi/exit-code-1)
11:09:50 PM:
11:09:50 PM: Error location
11:09:50 PM: In Build command from Netlify app:
11:09:50 PM: yarn build
11:09:50 PM:
11:09:50 PM: Resolved config
11:09:50 PM: build:
11:09:50 PM: command: yarn build
11:09:50 PM: commandOrigin: ui
11:09:50 PM: environment:
11:09:50 PM: - REACT_APP_PUBLIC_URL
11:09:50 PM: - REVIEW_ID
11:09:50 PM: publish: /opt/build/repo/build
11:09:50 PM: publishOrigin: ui
621e1ac
to
28a72d0
Compare
✅ Deploy Preview for microcov ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zack112358
force-pushed
the
validation-scenarios
branch
from
28a72d0
to
d6958f1
Compare
zack112358
force-pushed
the
validation-scenarios
branch
from
d6958f1
to
097b77e
Compare
|
Thanks for fixing up CI! Happy to give it a final look when you're ready. |
zack112358
force-pushed
the
validation-scenarios
branch
from
9f31892
to
afd2cf9
Compare
|
Assuming that CI passes, I think it's ready for re-review. |
zack112358
force-pushed
the
validation-scenarios
branch
from
afd2cf9
to
5558981
Compare
|
For clarity: I am not authorized to merge to "main" so I'll need you to push the merge button. |
|
Got it - must be more GitHub settings to fiddle with :) |
In this change, just the collection of model outputs for a grid of various inputs. Comparison tk soon with a jupyter notebook or the like. Can you recommend an older revision to try this change against to see what effect past model changes have had?
Regarding the issue I had previously with running scripts: I wound up just going with a test that dumps out a file as a side effect. It was easier than getting too into it.