Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Figure out how to list samples in the data portal #349

Open
3 tasks
pvangay opened this issue May 22, 2021 · 3 comments
Open
3 tasks

Figure out how to list samples in the data portal #349

pvangay opened this issue May 22, 2021 · 3 comments

Comments

@pvangay
Copy link

pvangay commented May 22, 2021

Samples are currently listed by study/proposal names, which can be misleading in some cases (as in #342), or too long to distinguish between samples (#340)

In 5/21/21 "docuthon" meeting, @mslarae13 @dehays @dwinston discussed options, which include one or more of:

  • sample_name (new datasets)
  • IGSN
  • UUID
  • local sample ID

Action items:

  • identify who needs to be included in the discussion / decision making
  • schedule meeting to determine an alternative to what we're doing currently
  • implement new alternative

Adding as listeners: @kfagnan @turbomam

@dehays
Copy link
Contributor

dehays commented May 23, 2021

This issue might be better off in nmdc-server (where, non intuitively, the client code is) because this is about how best to display an NMDC biosample. That display can only use the biosample attributes that are available. So this is not a question of whether to display an IGSN or a UUID, biosample has an id attribute that can take several forms: gold:, igsn: or emsl:. For gold: and igsn: sample ids the ID could be displayed to link back to the record indicated by the identifier. sample_name is a field on the MIxS 6, which would likely map to the NMDC biosample name field. The NMDC biosample name field is what is currently displayed in the UI.

@ssarrafan
Copy link

@dehays should this issue be added to the July sprint board?

@ssarrafan ssarrafan removed this from the Sprint 3 milestone Jul 6, 2021
@dehays
Copy link
Contributor

dehays commented Jul 6, 2021

@ssarrafan Yes - and there could be two tasks here. 1) Given the attributes of a biosample in NMDC, how should that biosample be displayed in the UI; i.e. what field values should be displayed and how should they be displayed. 2) There is also discussion about whether the GOLD biosample name should be used as the NMDC biosample name. GOLD biosample names default to a naming scheme that uses the sequencing project name combined with the researcher sample name. If we pursue this modification for name from GOLD to NMDC then there needs to be a naming scheme defined.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants