Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove acquisition_category slot and AcquisitionCategoryEnum #2018

Closed
kheal opened this issue May 30, 2024 · 3 comments
Closed

Remove acquisition_category slot and AcquisitionCategoryEnum #2018

kheal opened this issue May 30, 2024 · 3 comments
Labels
berkeley-fy24-refactor Label to describe issues created during the December 2023 hackathon for schema refactor

Comments

@kheal
Copy link

kheal commented May 30, 2024 •
edited
Loading

@corilo, @SamuelPurvine et al agreed to collapse these slots for simplicity and to better match mappings as uncovered during work for microbiomedata/issues#705

Remove acquisition_category slot and AcquisitionCategoryEnum.
Add "full-scan only" as a permissible value to AcquisitionStrategyEnum.
Rename EnumAcquisitionStrategyEnum to MassSpectrometryAcquisitionStrategyEnum
Rename slot acquisition_strategy to mass_spectrometry_acquisition_strategy
@kheal kheal added the berkeley-fy24-refactor Label to describe issues created during the December 2023 hackathon for schema refactor label May 30, 2024
@mslarae13 mslarae13 mentioned this issue May 30, 2024
Closed
@mslarae13
Copy link
Contributor

& update mass_spectrometryacquisition_strategy description from

description: whether spectra are dependent on or independent of any other spectra during the experiment

to

   description: Mode of running a mass spectrometer method by which m/z ranges are selected and ions possibly fragmented

@mslarae13
Copy link
Contributor

mslarae13 commented May 30, 2024 •
edited
Loading

See commit microbiomedata@11ade68

in microbiomedata#179

@mslarae13

This comment was marked as resolved.

Sign in to view
@kheal kheal mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
berkeley-fy24-refactor Label to describe issues created during the December 2023 hackathon for schema refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kheal @mslarae13