Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study page updates #563

Closed
ssarrafan opened this issue Dec 6, 2021 · 19 comments · Fixed by #647
Closed

Study page updates #563

ssarrafan opened this issue Dec 6, 2021 · 19 comments · Fixed by #647
Assignees
Milestone

Comments

@ssarrafan
Copy link

GH issue for adding changes wanted on the study pages.

12/6/21: Would like the link to ESS-DIVE to be more prominent (logo?). Would like to have a mock-up to share with the ESS-DIVE team on January 24th.

@ssarrafan ssarrafan created this issue from a note in NMDC January 2022 Sprint (To do) Dec 6, 2021
@ssarrafan ssarrafan added this to the Sprint 10 milestone Dec 6, 2021
@ssarrafan
Copy link
Author

@faiza-a wondering if you have any questions about this issue?

@faiza-a
Copy link

faiza-a commented Jan 27, 2022

@ssarrafan Could you please point me to the logo we are referring here. and what was the ask. i need to refresh my memory on this.

@ssarrafan
Copy link
Author

@ssarrafan Could you please point me to the logo we are referring here. and what was the ask. i need to refresh my memory on this.

Hi @faiza-a,
The logo is the one at the top of this site https://ess-dive.lbl.gov
But I think we need some information from @emileyfadrosh on where she wants the logo.
The meeting on Jan 24th was canceled so we have till mid-February. Let's discuss with @emileyfadrosh when she's back next week.

@ssarrafan ssarrafan removed this from To do in NMDC January 2022 Sprint Jan 28, 2022
@ssarrafan ssarrafan added this to To do in NMDC February 2022 Sprint via automation Jan 28, 2022
@ssarrafan ssarrafan modified the milestones: Sprint 10, Sprint 11 Jan 28, 2022
@emileyfadrosh
Copy link

sorry for the delay! the logo should only be on the page where there is an ess-dive link, so here: https://data.dev.microbiomedata.org/details/study/gold:Gs0135149

would it be possible to add it like this?
Screen Shot 2022-02-17 at 9 22 07 AM

@pvangay thoughts?

@pvangay
Copy link

pvangay commented Feb 22, 2022

@faiza-a, links to the ESS-DIVE and GOLD systems are those that we want to make prominent if they are available (not all datasets have them), because they show the interconnectedness between DOE systems. I dont know if adding a logo to the left margin is the best option from a design perspective (imho, looks a little out of place), but it'd be great if you could provide some suggestions for how to incorporate a logo when these links are available for a given study. Hope this makes sense.

@ssarrafan
Copy link
Author

Moving to March. Let @faiza-a know via Slack that there are updates on the issue and to reach out if she needs more information.

@ssarrafan ssarrafan removed this from To do in NMDC February 2022 Sprint Feb 28, 2022
@ssarrafan ssarrafan added this to To do in NMDC March 2022 Sprint via automation Feb 28, 2022
@ssarrafan ssarrafan modified the milestones: Sprint 11, Sprint 12 Feb 28, 2022
@faiza-a
Copy link

faiza-a commented Mar 4, 2022

Sorry for late response. i was on vacation.
Here are a few variation for placing logo. Let me know if any of these works. or if there are any other suggestions i can quickly create those.


option1


option2


option3


option4


option5


option6


option7


Can also show ESS dive link upon hover over logo.

Screen Shot 2022-03-04 at 2 12 31 PM

@pvangay
Copy link

pvangay commented Mar 4, 2022

Thanks @faiza-a. I like the last option the best - it's cleanest.

Thoughts @emileyfadrosh ?

@jeffbaumes
Copy link
Collaborator

One other thought is to replace the link icon with the ESS DIVE icon (no words like the last example) which would keep everything else in line. @faiza-a can you show us how that would look?

@faiza-a
Copy link

faiza-a commented Mar 4, 2022

@jeffbaumes
Screen Shot 2022-03-04 at 2 32 11 PM

@ssarrafan ssarrafan moved this from To do to In progress in NMDC March 2022 Sprint Mar 4, 2022
@ssarrafan
Copy link
Author

@pvangay and @emileyfadrosh can you confirm which design you prefer for @faiza-a?

@pvangay
Copy link

pvangay commented Mar 11, 2022

I think that last image looks great!

@emileyfadrosh
Copy link

I prefer the latest version with the logo as the link, and without the link icon. We had a discussion at the infrastructure sync yesterday about doing the same for other resources we link out too. It would be great to follow the same for GOLD, IMG, and NCBI. Attached are the links:

GOLD:
image
IMG:
image
NCBI:
image

@pvangay is this OK?

@ssarrafan
Copy link
Author

@faiza-a thanks for putting all the options together. If it's ok I will re-assign this to @subdavis for implementation.

@ssarrafan
Copy link
Author

@emileyfadrosh do you want to get feedback from the ESS DIVE team? Or can we have @subdavis move forward with implementation of this?

@ssarrafan ssarrafan removed this from In progress in NMDC March 2022 Sprint Apr 1, 2022
@ssarrafan ssarrafan added this to To do in NMDC April 2022 Sprint via automation Apr 1, 2022
@ssarrafan ssarrafan modified the milestones: Sprint 12, Sprint13 Apr 1, 2022
@kfagnan
Copy link

kfagnan commented Apr 7, 2022

This looks good and I think we should move forward with implementation.

@ssarrafan ssarrafan moved this from To do to In progress in NMDC April 2022 Sprint Apr 7, 2022
@faiza-a
Copy link

faiza-a commented Apr 7, 2022

Based on our meeting discussion
with gold

@ssarrafan
Copy link
Author

Based on our meeting discussion
with gold

This looks great @faiza-a. Approved by the team at the infrastructure meeting today. @subdavis this is ready for implementation. Thank you

subdavis added a commit that referenced this issue Apr 18, 2022
@subdavis subdavis mentioned this issue Apr 18, 2022
NMDC April 2022 Sprint automation moved this from In progress to Done Apr 19, 2022
subdavis added a commit that referenced this issue Apr 19, 2022
@subdavis
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants