New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Study page updates #563
Comments
@faiza-a wondering if you have any questions about this issue? |
@ssarrafan Could you please point me to the logo we are referring here. and what was the ask. i need to refresh my memory on this. |
Hi @faiza-a, |
sorry for the delay! the logo should only be on the page where there is an ess-dive link, so here: https://data.dev.microbiomedata.org/details/study/gold:Gs0135149 would it be possible to add it like this? @pvangay thoughts? |
@faiza-a, links to the ESS-DIVE and GOLD systems are those that we want to make prominent if they are available (not all datasets have them), because they show the interconnectedness between DOE systems. I dont know if adding a logo to the left margin is the best option from a design perspective (imho, looks a little out of place), but it'd be great if you could provide some suggestions for how to incorporate a logo when these links are available for a given study. Hope this makes sense. |
Moving to March. Let @faiza-a know via Slack that there are updates on the issue and to reach out if she needs more information. |
Thanks @faiza-a. I like the last option the best - it's cleanest. Thoughts @emileyfadrosh ? |
One other thought is to replace the link icon with the ESS DIVE icon (no words like the last example) which would keep everything else in line. @faiza-a can you show us how that would look? |
@pvangay and @emileyfadrosh can you confirm which design you prefer for @faiza-a? |
I think that last image looks great! |
I prefer the latest version with the logo as the link, and without the link icon. We had a discussion at the infrastructure sync yesterday about doing the same for other resources we link out too. It would be great to follow the same for GOLD, IMG, and NCBI. Attached are the links: @pvangay is this OK? |
@emileyfadrosh do you want to get feedback from the ESS DIVE team? Or can we have @subdavis move forward with implementation of this? |
This looks good and I think we should move forward with implementation. |
GH issue for adding changes wanted on the study pages.
12/6/21: Would like the link to ESS-DIVE to be more prominent (logo?). Would like to have a mock-up to share with the ESS-DIVE team on January 24th.
The text was updated successfully, but these errors were encountered: