Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOI broken in Bioscales study page #606

Closed
pvangay opened this issue Feb 22, 2022 · 13 comments
Closed

DOI broken in Bioscales study page #606

pvangay opened this issue Feb 22, 2022 · 13 comments
Assignees
Labels
type: bug Something isn't working
Milestone

Comments

@pvangay
Copy link

pvangay commented Feb 22, 2022

"Other Publications" Link looks odd to be pointing to OSTI for Bioscales. Also, clicking on the DOI takes you to an undefined DOI. @dehays can you help sort out what might be causing this?

image

@pvangay pvangay added the type: bug Something isn't working label Feb 22, 2022
@dehays
Copy link
Contributor

dehays commented Feb 23, 2022

First - all three references to DOIs on the BioScales study page are the same DOI. It is the DOI associated with the OSTI Award. Going to the OSTI Award page is the correct behavior. There are no DOIs here that are associated with either data sets or publications.

Second - The DOI link on the left of the study page and the link out from the "Dataset Citation" section both work. There is an issue with the link out from the "Other publications" section.

@dehays
Copy link
Contributor

dehays commented Jul 8, 2022

If this is still an issue, I suggest looking at 1) the attributes on the study JSON document and 2) how the data portal is building the study UI. That likely means Montana on the metadata management (use the API to examine the study JSON) and Matt/Brandon from Kitware. I recall there were some study values that were retrieved 'out of band' as short terms fixes to study displays - someone would need to look at the data portal app to see if that is related.

Assigning to Montana

@dehays dehays assigned mslarae13 and unassigned dehays Jul 8, 2022
@mslarae13
Copy link

If i'm understanding this issue right. The only DOI that should be listed & is correct is Study : https://doi.org/10.46936/10.25585/60000017

Having this same DOI for the data sets & publications is incorrect. So, these 2 should be replaced with correct DOIs.
I'm assuming Stan or Chris would have the DOI information for these if they exists.

@mslarae13
Copy link

mslarae13 commented Jul 29, 2022

@ssarrafan can you bring this into Aug sprint.
Should be a straightforward change sheets fix

@ssarrafan ssarrafan added this to the Sprint 17 milestone Jul 29, 2022
@mslarae13
Copy link

Checking in with @emileyfadrosh before emailing Chris and Stan.

@emileyfadrosh
Copy link

Thanks for checking @mslarae13 -- you are correct, only the DOI should be listed for data set citation. No publications yet. I think this was a hack for GSP. Please use https://doi.org/10.46936/10.25585/60000017 for the data set DOI.

@mslarae13
Copy link

mslarae13 commented Aug 16, 2022

Thanks @emileyfadrosh ! So the DOI that's in publications need removed...
That link is broken for me? Says page not found?
Also, isn't that the project or proposal DOI? Not the dataset DOI?

@emileyfadrosh
Copy link

Sorry, yes: the DOIs from JGI are proposal-level DOIs, not data set DOIs. Perhaps this needs to be updated in the schema to reflect the correct terms going forward? @mslarae13 @turbomam

@ssarrafan
Copy link

@jeffbaumes moving to Sept but if nobody is working on it in the next 2 weeks please let me know

@ssarrafan ssarrafan modified the milestones: Sprint 17, Sprint 18 Sep 1, 2022
@jeffbaumes
Copy link
Collaborator

The underlying cause and plan for resolution is #772. Please put that one in the Sep sprint.

@ssarrafan
Copy link

The underlying cause and plan for resolution is #772. Please put that one in the Sep sprint.

Ok I added 772. Should it be assigned to Matt?

@jeffbaumes
Copy link
Collaborator

Ok I added 772. Should it be assigned to Matt?

Yes

@ssarrafan
Copy link

This is a duplicate of #772 so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

6 participants