-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataHarmonizer's linkml-datastructure branch doesn't use our validation rules #104
Comments
“{float} {unit}” string serialization is interpolation where the things in curly brackets are slots |
full_name: string_serialization: “{given} {family}” intent is to assemble/serialize a string from smaller value components means that things with a But we have erroneously put what should be MIxS structured patterns into string_serialization slots |
structured pattern: intent is to validate (reuse of smaller validation components) |
On course to make a PR which adds |
@sujaypatil96 @ssarrafan I see some good developments for this issue in #115, but I don't think I understand how to use it. I have added some discussion about this to the dh_testing README |
Validation rules currently come from the validation_converter sheet and are processed by
sheets_and_friends/converters/linkml2dataharmonizer.py
That gets bypassed when we use DataHarmonizer's linkml-datastructure branch, which takes our
nmdc_dh.yaml
as inputsee also cidgoh/DataHarmonizer#290
The text was updated successfully, but these errors were encountered: