Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalise the data representation #469

Closed
r59q opened this issue Apr 30, 2024 · 0 comments · May be fixed by #484
Closed

Generalise the data representation #469

r59q opened this issue Apr 30, 2024 · 0 comments · May be fixed by #484
Assignees
Milestone

Comments

@r59q
Copy link
Collaborator

r59q commented Apr 30, 2024

There are issues in the architecture regarding how we type-check the data, as a result stuff like magnetic values might become harder, as the generics are currently coded to infer types for the MicrobitAccelerometer data type deeply within the codebase. This should be fixed before adding magnetic sensor data as an option. Maybe having a generic that is known at compile-time isnt the best solution for this. Maybe we should generalize it to a vector of variable length and make implementations that announce their size and description?

@r59q r59q added this to the v3.2.0 milestone May 1, 2024
@r59q r59q linked a pull request May 6, 2024 that will close this issue
@r59q r59q removed a link to a pull request May 23, 2024
@r59q r59q self-assigned this May 23, 2024
@r59q r59q closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant