Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use text-encoder-lite for encoding #6

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Use text-encoder-lite for encoding #6

merged 2 commits into from
Feb 22, 2019

Conversation

microbit-rosslowe
Copy link
Contributor

Replace 'text-encoding' with 'text-encoder-lite' for encoding; reducing build size.

@microbit-rosslowe
Use text-encoder-lite for encoding
307067d 
Replace 'text-encoding' with 'text-encoder-lite' for encoding; reducing build size.
microbit-carlos
microbit-carlos reviewed Feb 21, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
@microbit-rosslowe microbit-rosslowe mentioned this pull request Feb 21, 2019
Merged
@microbit-carlos
Copy link
Collaborator

This looks ready for merge 👍

@microbit-carlos
Copy link
Collaborator

Dependency information:

@microbit-rosslowe microbit-rosslowe marked this pull request as ready for review February 22, 2019 09:55
microbit-carlos
microbit-carlos approved these changes Feb 22, 2019
View reviewed changes
Copy link
Collaborator

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ross!

@microbit-carlos microbit-carlos merged commit f7a932d into master Feb 22, 2019
@microbit-carlos microbit-carlos deleted the characters-lite branch February 22, 2019 10:23
@microbit-carlos microbit-carlos mentioned this pull request Feb 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microbit-carlos microbit-carlos microbit-carlos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@microbit-rosslowe @microbit-carlos