Alternative: Add configuration commands to MicrobitSerial #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview build will be at |
Comment on lines
86
to
94
| const messageResponse = protocol.processResponseMessage(msg); | ||
| if (!messageResponse) { | ||
| return; | ||
| } | ||
| const responseResolve = this.responseMap.get(messageResponse.messageId); | ||
| if (responseResolve) { | ||
| this.responseMap.delete(messageResponse.messageId); | ||
| responseResolve(messageResponse); | ||
| } |
There was a problem hiding this comment.
As we are struggling with performance, we could avoid doing this on every periodic message by either returning at the end of the if (sensorData) {} scope or only running this code if sensorData was undefined.
There was a problem hiding this comment.
Absolutely, thanks. 3dcd962
microbit-matt-hillsdon
changed the title
microbit-carlos
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #196 but reuses the request/response code for the handshake and sticks to one listener processing incoming data.
I've dropped the state field for now as we didn't really make much use of it after this change as state is now really held by the caller of the listenToInputServices and states during that call aren't useful anymore. I guess we could use it to ignore unexpected incoming periodic data but I think it's likely fine for the UI to always reflect what's going on with incoming data.
Until we test it for real I have litte/no faith in partial reconnections so planning to leave Rob to try those once his initial work as landed.