Check that Web Bluetooth is available #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bluetooth can be blocked by system policies.
|
Preview build will be at |
microbit-grace
approved these changes
Feb 12, 2024
| @@ -20,7 +20,7 @@ import { DeviceRequestStates } from '../microbit-interfacing/MicrobitConnection' | |||
| let text: (key: string, vars?: object) => string; | |||
| t.subscribe(t => (text = t)); | |||
|
|
|||
| export const compatibility = writable<CompatibilityStatus>(checkCompatibility()); | |||
| export const compatibility = writable<CompatibilityStatus>(await checkCompatibility()); | |||
There was a problem hiding this comment.
How worried should I be that this has regressed browser compatibility by using top-level await?
There was a problem hiding this comment.
Very broken on Chrome 88:
Uncaught SyntaxError: Unexpected reserved word
There was a problem hiding this comment.
Making this a draft until resolved.
There was a problem hiding this comment.
We have another one in i18n.ts:
await init({
fallbackLocale: 'en',
initialLocale: get(persistantLocale),
// Needed to format <link> style tags.
ignoreTag: false,
});
There was a problem hiding this comment.
This is already broken for Chrome 88 due to the await in i18n.ts. We'll come back to this later to attempt to target es2017 and lose both top-level awaits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bluetooth can be blocked by system policies and this additional check determines if this is the case.