Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with older browsers #227

Merged
merged 7 commits into from
Feb 22, 2024

Conversation

microbit-robert
Copy link

@microbit-robert microbit-robert commented Feb 13, 2024

Avoid using top-level await and target es2017 to improve compatibility with older browsers.

Avoid using top-level await to improve compatibility with older
browsers.
Copy link

Preview build will be at
https://review-ml.microbit.org/synchronous-i18n/thenextgen/

@microbit-robert
Copy link
Author

Needs BrowserStack testing.

@microbit-robert microbit-robert changed the title Synchronous i18n loading Improve compatibility with older browsers Feb 22, 2024
@microbit-robert microbit-robert marked this pull request as ready for review February 22, 2024 12:21
Copy link

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good to me. I don't have access to BrowserStack and Matt might want to comment so will leave it for him to review

@microbit-robert
Copy link
Author

Performance metrics will take a hit since we show nothing until the languages are loaded.

@microbit-matt-hillsdon
Copy link

Video relies on aspect ratio so looks a bit daft but otherwise the homepage is now OK on Safari 14.1. OK in v15.6. Melt UI doesn't have an aspect ratio component.

image

Copy link

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge. I'll do a bit more testing of the recent changes before a release.

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit 254bb4c into main Feb 22, 2024
1 check passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the synchronous-i18n branch February 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants