Dialog behaviour fixes #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only fire escape listener to close dialog while dialog is open. Stop calling open functions on app load.
|
Preview build will be at |
Comment on lines
57
to
61
| const keyListener = (event: KeyboardEvent) => { | ||
| if (event.key === 'Escape') { | ||
| if (event.key === 'Escape' && isOpen) { | ||
| onCloseDialog(); | ||
| } | ||
| }; |
There was a problem hiding this comment.
It's so unexpected how the key listener is listening even when the dialog is not opened. I guess it's because the conditional that determines whether the dialog is being rendered is in this component itself so regardless of the state of the dialog this script runs? Yikes, didn't think of that before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only fire escape listener to close dialog while dialog is open. Stop calling open functions on app load.
See https://microbit-global.monday.com/boards/1356069004/views/10076885/pulses/1404321523