Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog for redirecting UK primary school teachers to next gen ML tool #243

Merged
merged 29 commits into from
Feb 29, 2024

Conversation

microbit-grace
Copy link

@microbit-grace microbit-grace commented Feb 27, 2024

  • Shown to users before browser compatibility warning dialog.
  • Shown only if they are detected to be in the UK (GB), Isle of Man (IM), Jersey (JE), or Guernsey (GG).
  • Should only be shown once to the user.
Screenshot 2024-02-29 at 12 57 59

Design has been approved

Copy link

github-actions bot commented Feb 27, 2024

Preview build will be at
https://review-ml.microbit.org/local-api-proxy

@microbit-grace microbit-grace changed the title Add local api proxy Redirect UK primary school teachers to next gen ML tool Feb 28, 2024
@microbit-grace microbit-grace marked this pull request as draft February 28, 2024 13:22
src/App.svelte Outdated Show resolved Hide resolved
src/App.svelte Outdated Show resolved Hide resolved
@microbit-grace microbit-grace changed the title Redirect UK primary school teachers to next gen ML tool Dialog for redirecting UK primary school teachers to next gen ML tool Feb 29, 2024
microbit-grace and others added 2 commits February 29, 2024 13:55
Co-authored-by: Matt Hillsdon <44397098+microbit-matt-hillsdon@users.noreply.github.com>
Co-authored-by: Matt Hillsdon <44397098+microbit-matt-hillsdon@users.noreply.github.com>
Copy link

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@microbit-grace microbit-grace merged commit 0aa4729 into main Feb 29, 2024
1 check passed
@microbit-grace microbit-grace deleted the local-api-proxy branch February 29, 2024 14:01
microbit-grace added a commit that referenced this pull request Feb 29, 2024
…#243)

- Shown to users before browser compatibility warning dialog
- Shown only if they are detected to be in the UK (GB), Isle of Man (IM), Jersey (JE), or Guernsey (GG)
- Should only be shown once to the user
- API proxy for calling browser info endpoint for local dev via .env

(cherry picked from commit 0aa4729)
microbit-grace added a commit that referenced this pull request Feb 29, 2024
…#243)

- Shown to users before browser compatibility warning dialog
- Shown only if they are detected to be in the UK (GB), Isle of Man (IM), Jersey (JE), or Guernsey (GG)
- Should only be shown once to the user
- API proxy for calling browser info endpoint for local dev via .env

(cherry picked from commit 0aa4729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants