forked from microbit-foundation/cctd-ml-machine
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog for redirecting UK primary school teachers to next gen ML tool #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview build will be at |
95e374f
to
33b6987
Compare
microbit-grace
commented
Feb 28, 2024
microbit-grace
commented
Feb 28, 2024
microbit-grace
commented
Feb 28, 2024
Move api.ts and local-storage.ts to existing script/utils dir instead of creating a new utils dir
Renamed "toNextGen" references to "toOtherVersion" so that it would be easier to copy when updating the Next Gen version of the tool.
Co-authored-by: Matt Hillsdon <44397098+microbit-matt-hillsdon@users.noreply.github.com>
Co-authored-by: Matt Hillsdon <44397098+microbit-matt-hillsdon@users.noreply.github.com>
microbit-matt-hillsdon
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
microbit-grace
added a commit
that referenced
this pull request
Feb 29, 2024
…#243) - Shown to users before browser compatibility warning dialog - Shown only if they are detected to be in the UK (GB), Isle of Man (IM), Jersey (JE), or Guernsey (GG) - Should only be shown once to the user - API proxy for calling browser info endpoint for local dev via .env (cherry picked from commit 0aa4729)
microbit-grace
added a commit
that referenced
this pull request
Feb 29, 2024
…#243) - Shown to users before browser compatibility warning dialog - Shown only if they are detected to be in the UK (GB), Isle of Man (IM), Jersey (JE), or Guernsey (GG) - Should only be shown once to the user - API proxy for calling browser info endpoint for local dev via .env (cherry picked from commit 0aa4729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design has been approved