Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw insufficient data error when expected #250

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

microbit-robert
Copy link

If you connect a micro:bit while viewing the test model page with a trained model, we expect that there won't be enough data initially to make a prediction.

If you connect a micro:bit while viewing the test model page with a
trained model, we expect that there won't be enough data initially to
make a prediction.
Copy link

github-actions bot commented Mar 5, 2024

Preview build will be at
https://review-ml.microbit.org/insufficient-data

Copy link

@microbit-grace microbit-grace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microbit-robert
Copy link
Author

We'll also need to cherry pick this for the maint-nextgen branch.

@microbit-robert microbit-robert changed the base branch from main to maint-nextgen March 6, 2024 09:33
@microbit-robert microbit-robert changed the base branch from maint-nextgen to main March 6, 2024 09:33
Copy link

@microbit-matt-hillsdon microbit-matt-hillsdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll cherry-pick this to nextgen

@microbit-matt-hillsdon microbit-matt-hillsdon merged commit f7695eb into main Mar 6, 2024
2 checks passed
@microbit-matt-hillsdon microbit-matt-hillsdon deleted the insufficient-data branch March 6, 2024 09:37
microbit-matt-hillsdon pushed a commit that referenced this pull request Mar 6, 2024
If you connect a micro:bit while viewing the test model page with a
trained model, we expect that there won't be enough data initially to
make a prediction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants