Chane ML Events from enum to classes so they can be expanded in autogenerated file. #4
Conversation
| //% block="Circle" | ||
| Circle = 3, | ||
| namespace mlrunner { | ||
| export namespace Action { |
There was a problem hiding this comment.
I've added a nested namespace to make the Javascript code more readable and, since this is user defined, it avoids accidental overshadowing of existing variables/functions in the top mlrunner namespace.
pxtextension.ts
Outdated
| @@ -35,7 +31,7 @@ namespace mlrunner { | |||
| } | |||
| const actionLabels = actions.map((action, i) => ({ | |||
| name: action, | |||
| value: i + 1, | |||
| value: i + 2, | |||
There was a problem hiding this comment.
Because "None" needs to have a non-zero value, the user labels start at value "2", so I assumed this needs to be increased, but I'm not able to test it.
Alternatively we could check if the events can take negative values and make None = -1, but this is easier.
pxtextension.ts
Outdated
| } | ||
| // End simulator code. | ||
|
|
||
|
|
||
| //% fixedInstances | ||
| //% blockNamespace=mlrunner | ||
| class MlEvent { |
There was a problem hiding this comment.
Not sure why, but it didn't work if the class was defined inside the namespace, so had to break it out.
Update autogenerated code so None can be triggered from the sim.
|
@microbit-carlos I've changed the actions so they are an array of MlEvent instances and moved it inside the Actions namespace. The autogenerated has also been updated so we always have the ability to simulate "None". |
The blocks end up looking the same:
But rather than having an enum and types, which might force us through MakeCode features that we know have some bugs (microsoft/pxt-microbit#5695) we can use classes, with each "Ml event" being an instance of the class. This way we can create multiple instances in different files, so we can start with the "None" event (we'll need to think of a better name) and add extra events in the editor extension autogenerated files with the model and the labels.
@microbit-robert I've only tested this locally, are you able to test it in your environments to confirm if it works?