Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code structure] Full highlight doesn't update after horizontal scroll #253

Closed
martinwork opened this issue Aug 25, 2021 · 5 comments
Closed

Comments

@martinwork
Copy link

Bug Description

Full code structure highlight doesn't update after horizontal scroll

How To Reproduce

Steps to reproduce the behavior:

  1. Go to 'https://python.microbit.org/v/alpha'
  2. Make the browser window narrower
  3. Scroll across
  4. See error

Expected behavior

The shaded are should update

Screenshots

image

Environment

Desktop (please complete the following information):

  • OS: [e.g. iOS] Windows
  • Browser [e.g. chrome, safari] Chrome
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Add any other context about the problem here.

@microbit-matt-hillsdon microbit-matt-hillsdon changed the title Full code structure highlight doesn't update after horizontal scroll [Code structure] Full highlight doesn't update after horizontal scroll Aug 27, 2021
@microbit-matt-hillsdon
Copy link
Collaborator

microbit-matt-hillsdon commented Aug 27, 2021

Interesting, thanks. 638b98c was in a similar area though focussed on window resizes.

@JohnVidler
Copy link

Depth markers get weird with this too at deep depths:
Screenshot2022_04_26_113937
Screenshot2022_04_26_114210

@microbit-matt-hillsdon
Copy link
Collaborator

microbit-matt-hillsdon commented May 26, 2022

The original issue has a work-in-progress fix on #752.

I expected it to fix #253 (comment) too but that one seems stranger. You can repro it with a narrow window and much less content. It happens to the first block that overflows the width of the editor (and so requires scrolling).

@microbit-matt-hillsdon
Copy link
Collaborator

The second issue on this ticket appears to be unrelated to code structure highlighting.

image

If you look carefully the line indicator also stops short. The content editable is not growing in this circumstance which seems likely to cause other bugs. The text still looks ok as it overflows. I'll see if I can reproduce it in a more minimal setup.

@microbit-matt-hillsdon
Copy link
Collaborator

Raised #753 for the editor size/scroll issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants