Improve accessibility #26
Merged
+73
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamanoku
reviewed
Aug 29, 2021
yamanoku
reviewed
Aug 29, 2021
src/useOverlay.tsx
Outdated
Comment on lines
60
to
66
| document.getElementById(rootElementId)?.setAttribute('aria-hidden', 'true'); | ||
| document.body.addEventListener('keydown', handleKeydown); | ||
|
|
||
| return () => { | ||
| document.getElementById(rootElementId)?.removeAttribute('aria-hidden'); | ||
| document.body.removeEventListener('keydown', handleKeydown); | ||
| }; |
There was a problem hiding this comment.
Suggested change
| document.getElementById(rootElementId)?.setAttribute('aria-hidden', 'true'); | |
| document.body.addEventListener('keydown', handleKeydown); | |
| return () => { | |
| document.getElementById(rootElementId)?.removeAttribute('aria-hidden'); | |
| document.body.removeEventListener('keydown', handleKeydown); | |
| }; | |
| document.body.addEventListener('keydown', handleKeydown); | |
| return () => { | |
| document.body.removeEventListener('keydown', handleKeydown); | |
| }; |
Since aria-hidden="true" will be added to the entire root to be mounted, and the modal itself will be hidden, this description should not be used for accessibility reasons.
There was a problem hiding this comment.
Ok, I'll remove it and remove rootElementId from the arguments of this hook.
Co-authored-by: Okuto Oyama <0910yama@gmail.com>
|
@dqn Could you resolve the conflict? |
…into accessibility
|
@shibe97 It's done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a proposal