Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recent change results in html attributes potentially being repeated twice. #9

Closed
dmitshur opened this issue Aug 30, 2014 · 2 comments
Closed

Recent change results in html attributes potentially being repeated twice. #9

dmitshur opened this issue Aug 30, 2014 · 2 comments

Comments

@dmitshur
Copy link
Contributor

See 63440de#commitcomment-7587904 for details.
dmitshur referenced this issue Aug 30, 2014
@buro9
Added two new link methods, one restricts the use of rel='nofollow' t…
63440de 
…o fully qualified links only, and the other allows you to define a policy in which fully qualified links are forced into target='blank'
buro9 added a commit that referenced this issue Sep 2, 2014
@buro9
Resolved issue #9 which caused attributes to be duplicated when certa…
88042e4 
…in combinations of anchor options were used by the policy.
@buro9
Copy link
Member

buro9 commented Sep 2, 2014

Resolved by 88042e4 which makes the code a little clearer as well as preventing attributes being added twice.

@buro9 buro9 closed this as completed Sep 2, 2014
@dmitshur
Copy link
Contributor Author

dmitshur commented Sep 3, 2014

Confirmed fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@buro9 @dmitshur