Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version to 3.6 #4

Closed
microdaq opened this issue Aug 12, 2019 · 1 comment · Fixed by #11
Closed

Update version to 3.6 #4

microdaq opened this issue Aug 12, 2019 · 1 comment · Fixed by #11
Assignees

Comments

@microdaq
Copy link
Owner

# MLink Python2.7 binding

@microdaq microdaq self-assigned this Aug 12, 2019
@witczenko
Copy link
Collaborator

To close with PR #10

@witczenko witczenko mentioned this issue Nov 11, 2020
witczenko added a commit that referenced this issue Dec 1, 2020
### API changes
#### Rename package name and MLink class
- `py_mlink ` package change  to `microdaq`
- `MLink `class name change  to `Device`

New

    import microdaq
    mdaq = microdaq.Device(ip='10.10.1.1')

Old

    from py_mlink import PyMLink
    mdaq = PyMLink.MLink('10.10.1.1')

#### Exceptions
The `MLinkError` exception is throw only as a result of the MLink library call.\
The `ValueError` exception is throw as a result of parameter pre-check before calling MLink library.

#### Rename parameters

- `pwm_module` -> `module` in pwm_init, pwm_write methods
- `encoder` -> `module` in enc_init, enc_read methods
- `led_id` -> `led` in led_write method

#### Fixes
- Fix missing parameter in `ao_scan_trigger_encoder`

### Other

- Prepare installation script and package structure to be distributed over `pip` manager
- Add more examples
- Add tests for API integration (for contributors). Introduction of pytest
- Update README to me more friendly for new users

### Related issues
Closes #4
Closes #8
@witczenko witczenko mentioned this issue Dec 1, 2020
witczenko added a commit that referenced this issue Dec 1, 2020
### API changes
#### Rename package name and MLink class
- `py_mlink ` package change  to `microdaq`
- `MLink `class name change  to `Device`

New

    import microdaq
    mdaq = microdaq.Device(ip='10.10.1.1')

Old

    from py_mlink import PyMLink
    mdaq = PyMLink.MLink('10.10.1.1')


#### Exceptions
The `MLinkError` exception is throw only as a result of the MLink library call.\
The `ValueError` exception is throw as a result of parameter pre-check before calling MLink library. 

#### Rename parameters

- `pwm_module` -> `module` in pwm_init, pwm_write methods
- `encoder` -> `module` in enc_init, enc_read methods
- `led_id` -> `led` in led_write method

#### Fixes
- Fix missing parameter in `ao_scan_trigger_encoder`

### Other

- Prepare installation script and package structure to be distributed over `pip` manager
- Add more examples
- Add tests for API integration (for contributors). Introduction of pytest
- Update README to me more friendly for new users

### Related issues
Closes #4
Closes #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants