Removed syscall package #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slot
reviewed
Dec 13, 2017
config/config.go
Outdated
| // if mandatory but not found add them to error list | ||
| if found == false && parameter.Mandatory == true { | ||
| if envValue == "" && parameter.Mandatory == true { |
There was a problem hiding this comment.
we can not test env value for empty string because this might be a valid value, e.g. empty passwords. Please use os.LookupEnv() above on Line 61.
config/config.go
Outdated
| failedParameters = append(failedParameters, parameter) | ||
| continue | ||
| } | ||
|
|
||
| // Use default value if environment parameter is not set | ||
| if found == false && parameter.Mandatory == false { | ||
| if envValue == "" && parameter.Mandatory == false { |
It should not be used directly anymore. See https://golang.org/pkg/syscall
|
There were the following issues with your Pull Request
Guidelines are available at https://github.com/microdevs/missy This message was auto-generated by https://gitcop.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not be used directly anymore. See https://golang.org/pkg/syscall