Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Prometheus Histogram metric instead of Summary #26

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Conversation

learnjin
Copy link
Contributor

@learnjin learnjin commented Mar 6, 2018

because 'averaging the quantiles yields statistically nonsensical values.' We can calculate the cumulative aggregated p99 or pX on the server side.

Details see here: https://prometheus.io/docs/practices/histograms/

@GitCop
Copy link

GitCop commented Mar 6, 2018

There were the following issues with your Pull Request

  • Commit: 9bdc6bf
  • Commits must be in the following format: %{type}(%{scope}): %{description}
  • Your subject line is longer than 72 characters
  • Invalid type. Valid types are feat, fix, docs, style, refactor, perf, test, chore, revert

Guidelines are available at https://github.com/microdevs/missy


This message was auto-generated by https://gitcop.com

Copy link
Contributor

@slot slot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix you commit message with git commit --amend it should be like refactor(metrics): Use Prom...

@GitCop
Copy link

GitCop commented Mar 6, 2018

There were the following issues with your Pull Request

  • Commit: d261481
  • Your subject line is longer than 72 characters

Guidelines are available at https://github.com/microdevs/missy


This message was auto-generated by https://gitcop.com

@GitCop
Copy link

GitCop commented Mar 6, 2018

There were the following issues with your Pull Request

  • Commit: 7112a72
  • Your subject line is longer than 72 characters

Guidelines are available at https://github.com/microdevs/missy


This message was auto-generated by https://gitcop.com

@slot slot merged commit e0f2c6a into master Oct 12, 2018
@levrik levrik deleted the histogram branch October 12, 2018 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants