Add missing title XML escapes for video sitemap element #130
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenbinf
requested changes
Apr 18, 2024
edge-src/common/PageUtils.js
Outdated
| @@ -166,6 +166,16 @@ export class SitemapResponseBuilder extends ResponseBuilder { | |||
| return 'text/xml'; | |||
| } | |||
|
|
|||
| _escapeXML(str) { | |||
There was a problem hiding this comment.
We already have a similar function escapeHtml() at common-src/StringUtils.js -
microfeed/common-src/StringUtils.js
Line 185 in 438b68a
could you please use escapeHtml() instead of creating a duplicate function?
Thanks!
There was a problem hiding this comment.
Right missed that, rectified.
jarylc
force-pushed
the
xml-sitemap-escape
branch
from
25df049
to
010fe65
Compare
wenbinf
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed my sitemap failing when I have special characters in the title and have a video element in the sitemap.
It's caused by forgetting to escape the title as I used the title as is for the video title.
Ref: https://stackoverflow.com/questions/1091945/what-characters-do-i-need-to-escape-in-xml-documents