Skip to content

Commit

Permalink
failing when deployed to secondary machine because "set" in not set t…
Browse files Browse the repository at this point in the history 
…o require
  • Loading branch information
Ben Roberts committed Aug 27, 2018
1 parent dbda0ae commit e70ad04
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/microformats.rb
View file
@@ -1,6 +1,7 @@
require 'nokogiri'
require 'open-uri'
require 'json'
require 'set'

require 'microformats/version'
require 'microformats/absolute_uri'
Expand Down

3 comments on commit e70ad04

@jgarber623
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. Travis CI didn't fail on this?

@jgarber623
Copy link
Member

@jgarber623 jgarber623 commented on e70ad04 Aug 28, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I don't imagine it would. We're not currently testing that the gem builds and installs correctly. Hrm, I'll create a tracking issue for that. We may be able to do some interesting things with Travis CI.

Edit: Never mind, #101 tracks this.

Unrelated: I think you can pull a release from RubyGems with the yank command.

gem yank microformats -v 4.0.8

@dissolve
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, yanked.

The gem installed fine, but when i went to use it on that machine it crashed.

Please sign in to comment.