Remove failing codeclimate-action step #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
calebhearth
commented
Jan 24, 2023
calebhearth
commented
- Drop Ruby 2.4, 2.5, 2.6 support, as all are EOL
- Add Ruby 3.2 support
- Remove all version locks in gemspec
- Drop Ruby 2.4, 2.5, 2.6 support, as all are EOL - Add Ruby 3.2 support - Remove all version locks in gemspec
tantek
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
These seem like reasonable changes to me, reflecting what is intended, and hopefully making the code more future proof (i.e. more likely to "just run" in the future rather than oddly break because of a version number change somewhere else, which feels more fragile).
dissolve
approved these changes
Jan 25, 2023
|
merging without the travis build as it will never succeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.